[WC-3088] DataGrid: Row selection indicator #1907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

leonardomendix merged 14 commits into main from fix/wc-3088_datagrid-row-selection

Oct 24, 2025

Contributor

yordan-st commented Sep 19, 2025 •

edited

Loading

Pull request type

Bug fix (non-breaking change which fixes an issue)

Description

Added a new configuration option to show/hide selection count in the datagrid header and footer
Added configurable label for the clear selection button to support internationalization
Created a new SelectionCounter component that displays selection information
Improved layout and styling for better responsiveness across different screen sizes

What should be covered while testing?

Test different pagination options and how it looks on different viewport sizes
Enable / disable number of rows visibility
Toggle selection count to top / bottom / off
Change 'clear selection' text

github-actions bot added the data-widgets label

yordan-st changed the title ~~Fix/wc 3088 datagrid row selection~~ [WC-3088] DataGrid: Row selection indicator

yordan-st force-pushed the fix/wc-3088_datagrid-row-selection branch 2 times, most recently from fa68cf4 to c7622d9 Compare

September 19, 2025 14:15

yordan-st marked this pull request as ready for review

September 19, 2025 14:17

yordan-st requested a review from a team as a code owner

September 19, 2025 14:17

yordan-st force-pushed the fix/wc-3088_datagrid-row-selection branch 3 times, most recently from 07c86b0 to afb73a8 Compare

September 23, 2025 08:10

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/datagrid-web/src/components/WidgetTopBar.tsx Outdated Show resolved Hide resolved

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/datagrid-web/src/components/WidgetTopBar.tsx Outdated Show resolved Hide resolved

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/datagrid-web/src/components/WidgetTopBar.tsx Outdated Show resolved Hide resolved

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/datagrid-web/src/Datagrid.xml Outdated Show resolved Hide resolved

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/datagrid-web/src/Datagrid.tsx Outdated Show resolved Hide resolved

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/datagrid-web/src/components/Widget.tsx Outdated Show resolved Hide resolved

r0b1n reviewed

View reviewed changes

packages/pluggableWidgets/datagrid-web/src/components/WidgetFooter.tsx Outdated Show resolved Hide resolved

github-actions bot added shared charts-web combobox-web labels

yordan-st force-pushed the fix/wc-3088_datagrid-row-selection branch from 9ce3192 to d845151 Compare

September 26, 2025 08:52

github-actions bot removed charts-web combobox-web labels

yordan-st force-pushed the fix/wc-3088_datagrid-row-selection branch from d845151 to f4c904b Compare

September 29, 2025 11:33

samuelreichert previously approved these changes

View reviewed changes

Contributor

samuelreichert left a comment

Could you add a screenshot of how this looks like now?

yordan-st dismissed samuelreichert’s stale review via

8c1269d

October 8, 2025 13:14

yordan-st force-pushed the fix/wc-3088_datagrid-row-selection branch from f4c904b to 8c1269d Compare

October 8, 2025 13:14

samuelreichert previously approved these changes

View reviewed changes

yordan-st dismissed samuelreichert’s stale review via

e77f264

October 14, 2025 14:57

yordan-st force-pushed the fix/wc-3088_datagrid-row-selection branch 2 times, most recently from 31f56ef to 143f92d Compare

October 16, 2025 13:34

yordan-st force-pushed the fix/wc-3088_datagrid-row-selection branch 2 times, most recently from 6e9dc23 to bbfec30 Compare

October 17, 2025 09:00

yordan-st added 10 commits

October 21, 2025 11:49


          feat: add clear selection button label config

5d1d596


          feat: add selection count visibility to config

2318f04


          fix: reference to updated scss variable

3e57d67


          refactor: improve naming, reduce prop drilling and unify component re…

525b6bf

…ndering


          fix: change selection count position and visibility, enhance accessib…

ea45b9e

…ility support


          chore: enhance focus styles for accessibility in datagrid component

662006b


          fix: update focus-visible outline to use CSS variable for consistency

896e243


          fix: fix failing e2e

37560da


          fix: failing e2e

37b6328


          fix: remove unnecessary aria-label from clear selection button

0a8490d

yordan-st force-pushed the fix/wc-3088_datagrid-row-selection branch from 53c6a6e to 0a8490d Compare

October 21, 2025 09:50

leonardomendix and others added 4 commits

October 22, 2025 13:00


          test: update e2e screenshots baseline

c78a4da


          test: update dg2 e2e screenshots baseline


          fix: update selection count logic to include multi-selection type

af3b68c


          test: update dg2 single selection e2e screenshots baseline

c7d8ede

leonardomendix approved these changes

View reviewed changes

iobuhov approved these changes

View reviewed changes

leonardomendix merged commit cd866d2 into main

14 checks passed

leonardomendix deleted the fix/wc-3088_datagrid-row-selection branch

October 24, 2025 09:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data-widgets shared